fix(ui): cross-mode strip follow-ups from ticker review#419
Merged
Conversation
- Remove duplicate CrossModeLinksSection below answer (keep inline in surface) - Scope rail fade and hidden scrollbar to md+ only - Add list semantics and keyboard focus hint when multiple matches - Drop unused compact prop on CrossModeLinkActions - Assert single cross-mode strip in answer surface smoke test Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
BigSimmo
marked this pull request as ready for review
July 9, 2026 03:47
BigSimmo
enabled auto-merge (squash)
July 9, 2026 03:47
This was referenced Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Small follow-ups from the desktop ticker PR review — no behavior change to matching or navigation.
Fixes
CrossModeLinksSectioninClinicalDashboardfor answer mode; the inline strip inanswer-result-surfaceis the single source.md+(768px).role="list"/listitem; when multiple matches exist,tabIndex={0}and anaria-labelnote horizontal scroll.compactprop fromCrossModeLinkActions.Verification
npm run format:check— passednpx playwright test tests/ui-smoke.spec.ts -g "cross-mode quick links"— passed (includestoHaveCount(1))Not in scope
Supabase Preview branch migration state — infra-only, unrelated to UI.